Fix #417 Add serviceMonitor template for the telegraf chart #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Efrat19 <[email protected]>
Signed-off-by: Efrat19 <[email protected]>
alespour
requested changes
Oct 3, 2022
…af_servicemonitor
Signed-off-by: Efrat19 <[email protected]>
alespour
previously approved these changes
Oct 11, 2022
|
Hey is there anything else still needed to be done here? @tomklapka @alespour |
tomklapka
requested changes
Oct 20, 2022
…af_servicemonitor
Signed-off-by: Efrat Levitan <[email protected]>
|
Checks failed with Error: ServiceMonitor.monitoring.coreos.com "telegraf-1xv72y61rr" is invalid: spec.endpoints.port: Invalid value: "integer": spec.endpoints.port in body must be of type string: "integer". Please fix it. |
fixed |
|
@Efrat19 please rebase your branch to master and bump up the telegraf chart version (1.8.23 -> 1.8.24) Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Efrat19 [email protected]
addressing #417