Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - ci: parse input as boolean #3157

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - ci: parse input as boolean #3157

wants to merge 1 commit into from

Conversation

morenol
Copy link
Contributor

@morenol morenol commented Apr 17, 2023 •
edited
Loading

Note: The workflow will also receive the inputs in the github.event.inputs context. The information in the inputs context and github.event.inputs context is identical except that the inputs context preserves Boolean values as Booleans instead of converting them to strings.

https://docs.github.com/en/enterprise-cloud@latest/actions/using-workflows/workflow-syntax-for-github-actions#onworkflow_dispatchinputs

This should fix #3045

@morenol
ci: parse input as boolean
d95a7ff 
Note: The workflow will also receive the inputs in the github.event.inputs context. The information in the inputs context and github.event.inputs context is identical except that the inputs context preserves Boolean values as Booleans instead of converting them to strings.
@morenol morenol requested review from digikata and tjtelan April 17, 2023 18:46
@morenol
Copy link
Contributor Author

morenol commented Apr 17, 2023 •
edited
Loading

The input was parsed as string, so it seems that ! was being applied to a non-empty string instead of to a boolean value.

@digikata
Copy link
Contributor

This seems to get a lot of people, see actions/runner#1483

digikata
digikata approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morenol
Copy link
Contributor Author

morenol commented Apr 17, 2023

bors r+

bors bot pushed a commit that referenced this pull request Apr 17, 2023
@morenol
ci: parse input as boolean (#3157)
93a7046 
>> Note: The workflow will also receive the inputs in the github.event.inputs context. The information in the inputs context and github.event.inputs context is identical except that the inputs context preserves Boolean values as Booleans instead of converting them to strings.

https://docs.github.com/en/enterprise-cloud@latest/actions/using-workflows/workflow-syntax-for-github-actions#onworkflow_dispatchinputs

This should fix #3045
@bors
Copy link

bors bot commented Apr 17, 2023

Pull request successfully merged into master.

Build succeeded:

  • Done

@bors bors bot changed the title ci: parse input as boolean [Merged by Bors] - ci: parse input as boolean Apr 17, 2023
@bors bors bot closed this Apr 17, 2023
@bors bors bot deleted the morenol-patch-2 branch April 17, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digikata digikata digikata approved these changes

@tjtelan tjtelan Awaiting requested review from tjtelan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable crates publish after Release workflow
2 participants
@morenol @digikata