fix: smdk publish signing error w/ cross-fs tmp file (#2767)

infinyon · Nov 2, 2022 · c45e698 · c45e698
1 parent b5e52ce
commit c45e698
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/crates/fluvio-hub-util/src/package.rs b/crates/fluvio-hub-util/src/package.rs
@@ -226,11 +226,16 @@ pub fn package_sign(in_pkgfile: &str, key: &Keypair, out_pkgfile: &str) -> Resul
     signedpkg.finish()?;
     drop(signedpkg);
     signedfile.flush()?;
-    signedfile.persist(&out_pkgfile).map_err(|e| {
-        warn!("{}", e);
-        HubUtilError::PackageSigning(format!("{in_pkgfile}: fault creating signed package"))
-    })?;
-
+    let sf_path = signedfile.path().to_path_buf();
+    if let Err(e) = signedfile.persist(&out_pkgfile) {
+        warn!("{}, falling back to copy", e);
+        std::fs::copy(sf_path, &out_pkgfile).map_err(|e| {
+            warn!("copy failure {}", e);
+            HubUtilError::PackageSigning(format!(
+                "{in_pkgfile}: fault creating signed package\n{e}"
+            ))
+        })?;
+    }
     Ok(())
 }