Skip to content

feat(reactotron-core-ui): add copy button for nested objects in API response #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Deepakmukka1 wants to merge 1 commit into
base: master
Choose a base branch
from
+36 −5
Open

feat(reactotron-core-ui): add copy button for nested objects in API response #1597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/reactotron-core-ui/src/components/ContentView/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,10 @@ interface Props {
// value: object | string | number | boolean | null | undefined
value: any
treeLevel?: number
copyToClipboard?: (text: string) => void
}

export default function ContentView({ value, treeLevel }: Props) {
export default function ContentView({ value, treeLevel, copyToClipboard }: Props) {
if (value === null) return <NullContainer>null</NullContainer>
if (value === undefined) return <UndefinedContainer>undefined</UndefinedContainer>

Expand Down Expand Up @@ -54,7 +55,7 @@ export default function ContentView({ value, treeLevel }: Props) {
return isShallow(checkValue) ? (
makeTable(checkValue)
) : (
<TreeView value={checkValue} level={treeLevel} />
<TreeView value={checkValue} level={treeLevel} copyToClipboard={copyToClipboard} />
)
}

Expand Down
32 changes: 30 additions & 2 deletions lib/reactotron-core-ui/src/components/TreeView/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,22 @@ const theme = {

const MutedContainer = styled.span`
color: ${(props) => props.theme.highlight};
display: inline-flex;
`

const ButtonCopy = styled.button`
margin-left: 6px;
padding: 0 6px;
font-size: 10px;
border: none;
border-radius: 3px;
cursor: pointer;
color: ${(props) => props.theme.background};
background-color: ${(props) => props.theme.highlight};

&:hover {
opacity: 0.85;
}
`

const getTreeTheme = (baseTheme: ReactotronTheme) => ({
Expand All @@ -41,9 +57,10 @@ interface Props {
// value: object
value: any
level?: number
copyToClipboard?: (text: string) => void
}

export default function TreeView({ value, level = 1 }: Props) {
export default function TreeView({ value, level = 1, copyToClipboard }: Props) {
const colorScheme = useColorScheme()

return (
Expand All @@ -54,7 +71,18 @@ export default function TreeView({ value, level = 1 }: Props) {
theme={getTreeTheme(themes[colorScheme])}
getItemString={(type, data, itemType, itemString) => {
if (type === "Object") {
return <MutedContainer>{itemType}</MutedContainer>
const handleCopy = copyToClipboard
? (event: React.MouseEvent) => {
event.stopPropagation()
copyToClipboard(JSON.stringify(data, null, 2))
}
: undefined
return (
<MutedContainer>
{itemType}
{handleCopy && <ButtonCopy onClick={handleCopy}>Copy</ButtonCopy>}
</MutedContainer>
)
}

return (
Expand Down
4 changes: 3 additions & 1 deletion lib/reactotron-core-ui/src/timelineCommands/ApiResponseCommand/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,9 @@ const ApiResponseCommand: FunctionComponent<Props> = ({
{!!request.params && tabBuilder(Tab.RequestParams, "Request Params")}
{tabBuilder(Tab.RequestHeaders, "Request Headers")}
</TabsContainer>
{onTab === Tab.ResponseBody && <ContentView value={response.body} />}
{onTab === Tab.ResponseBody && (
<ContentView value={response.body} copyToClipboard={copyToClipboard} />
)}
{onTab === Tab.ResponseHeaders && <ContentView value={response.headers} />}
{onTab === Tab.RequestBody && <ContentView value={request.data} treeLevel={1} />}
{onTab === Tab.RequestParams && <ContentView value={request.params} />}
Expand Down