Removes storybook from codebase entirely, including storybook switch feature#1545
Open
jamonholmgren wants to merge 4 commits intomasterfrom
Open
Removes storybook from codebase entirely, including storybook switch feature#1545jamonholmgren wants to merge 4 commits intomasterfrom
jamonholmgren wants to merge 4 commits intomasterfrom
Conversation
22 tasks
frankcalise
reviewed
Mar 1, 2025
Contributor
frankcalise
left a comment
There was a problem hiding this comment.
Is it spring already? 🧹
Generally looks fine to me, spotted one yarn config change that I'm unsure what it does
silasjmatson
approved these changes
Mar 3, 2025
Contributor
silasjmatson
left a comment
There was a problem hiding this comment.
Thanks for separating the lint/formatting fixes into their own commit. It made this much more reviewable. ![]()
frankcalise
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rather large PR, but the actual changes are fairly limited in surface area. It's part of my new effort to streamline and simplify Reactotron's code base to make it easier to work on.
To review, mostly just look at the Storybook commit, unless you like looking at linting changes.
yarn build-and-test:localpassesREADME.md(or relevant documentation) has been updated with your changes