Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sets static builds in core podspec to prevent dependency conflicts #171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

younes0
Copy link
Contributor

@younes0 younes0 commented Oct 31, 2024

This PR configures RNMLKitCore.podspec to use static builds to prevent dependency conflicts
See: #169

Why

  • Prevents dependency conflicts when used alongside other libraries (like React Native Firebase)
  • Follows CocoaPods best practices for React Native modules

Impact

  • No negative impact on existing implementations
  • Helps prevent version conflicts with shared dependencies (like nanopb)
  • Minimal change that follows standard CocoaPods patterns

Testing

  • Tested with React Native Firebase
  • Verified basic MLKit functionality

Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: 8f06f6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant