-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add post-add event to collection js #64
Open
ste-wilkinson
wants to merge
6
commits into
infinite-networks:master
Choose a base branch
from
ste-wilkinson:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b809bb7
Added post-add event to collection js and updated docs
stephen-crowdreactive 6844949
Fixed document typo and optimised event trigger logic
stephen-crowdreactive f9a7ea5
Moved event creation before trigger
stephen-crowdreactive 77c9063
Fixed error causing existing tests to fail
stephen-crowdreactive e376974
Added test for item added event
stephen-crowdreactive 15436b0
Expect one assertion for added event test
stephen-crowdreactive File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -87,17 +87,24 @@ | |
var html = this._getPrototypeHtml($prototype, this.internalCount++), | ||
$row = $($.parseHTML(html, document, this.options.keepScripts)); | ||
|
||
var event = this._createEvent('infinite_collection_add'); | ||
event.$triggeredPrototype = $prototype; | ||
event.$row = $row; | ||
event.insertBefore = null; | ||
this.$collection.trigger(event); | ||
var addEvent = this._createEvent('infinite_collection_add'); | ||
addEvent.$triggeredPrototype = $prototype; | ||
addEvent.$row = $row; | ||
addEvent.insertBefore = null; | ||
|
||
if (!event.isDefaultPrevented()) { | ||
this.$collection.trigger(addEvent); | ||
|
||
var addedEvent = this._createEvent('infinite_collection_added'); | ||
addedEvent.$triggeredPrototype = $prototype; | ||
addedEvent.$row = $row; | ||
|
||
if (!addEvent.isDefaultPrevented()) { | ||
if (event.insertBefore) { | ||
$row.insertBefore(event.insertBefore); | ||
this.$collection.trigger(addedEvent); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This can be moved below the if and before the return to avoid repeating the same call in both branches. You should also only create the event before it is about to be fired, inside the isDefaultPrevented() check. |
||
} else { | ||
this.$collection.append($row); | ||
this.$collection.trigger(addedEvent); | ||
} | ||
|
||
return $row; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grammar:
dom elements that were added