Skip to content

feat: Add a custom header to the SDK for chatting with the agent.#12430

Merged
KevinHuSh merged 3 commits intoinfiniflow:mainfrom
LeiZhang-Hunter:main
Feb 3, 2026
Merged

feat: Add a custom header to the SDK for chatting with the agent.#12430
KevinHuSh merged 3 commits intoinfiniflow:mainfrom
LeiZhang-Hunter:main

Conversation

@LeiZhang-Hunter
Copy link
Copy Markdown
Contributor

@LeiZhang-Hunter LeiZhang-Hunter commented Jan 4, 2026

What problem does this PR solve?

As title.

Type of change

  • New Feature (non-breaking change which adds functionality)

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 4, 2026
@KevinHuSh KevinHuSh requested a review from asiroliu January 5, 2026 02:06
@KevinHuSh KevinHuSh added the ci Continue Integration label Jan 5, 2026
@KevinHuSh KevinHuSh marked this pull request as draft January 5, 2026 02:06
@KevinHuSh KevinHuSh marked this pull request as ready for review January 5, 2026 02:07
@asiroliu asiroliu requested a review from Magicbook1108 January 5, 2026 02:29
@asiroliu
Copy link
Copy Markdown
Collaborator

asiroliu commented Jan 5, 2026

@LeiZhang-Hunter

  1. I checked your PR—the changes are actually for the Web API, not the SDK.
  2. I'm concerned that custom headers could open us up to HTTP Header Injection and parsing risks, which aren't being handled in the current code.

@KevinHuSh KevinHuSh removed the ci Continue Integration label Jan 5, 2026
@LeiZhang-Hunter
Copy link
Copy Markdown
Contributor Author

  • I checked your PR—the changes are actually for the Web API, not the SDK.

  • I'm concerned that custom headers could open us up to HTTP Header Injection and parsing risks, which aren't being handled in the current code.

ragflow only doing pass-through; you don't need to worry about these things.

@asiroliu asiroliu added the ci Continue Integration label Feb 3, 2026
@asiroliu asiroliu marked this pull request as draft February 3, 2026 01:49
@asiroliu asiroliu marked this pull request as ready for review February 3, 2026 01:49
@dosubot dosubot Bot added the 💞 feature Feature request, pull request that fullfill a new feature. label Feb 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.46%. Comparing base (2e5a186) to head (1eff498).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12430   +/-   ##
=======================================
  Coverage   44.46%   44.46%           
=======================================
  Files          43       43           
  Lines        9266     9266           
  Branches      107      107           
=======================================
  Hits         4120     4120           
  Misses       5127     5127           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KevinHuSh KevinHuSh merged commit 7cbe8b5 into infiniflow:main Feb 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continue Integration 💞 feature Feature request, pull request that fullfill a new feature. size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants