Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements #629 - Port-Specific Custom VLAN Tag #630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tardoe
Copy link

@tardoe tardoe commented Apr 8, 2020

[NF] New feature summary - closes #629

Adds a customVlanTag parameter to the vlanInterface model and plumbs that through to the UI. This allows a member to have a Peering VLAN handed off on a virtualInterface with a customer port-specific tag. This has also been implemented with the provisioning flow to add a customVlanTag field to the generated YAML file.

I've also included a migration that works against previous versions of the installation.

In addition to the above, I have:

  • ensured all relevant template output is escaped to avoid XSS attached with <?= $t->ee( $data ) ?> or equivalent.
  • ensured appropriate checks against user privilege / resources accessed
  • API calls (particular for add/edit/delete/toggle) are not implemented with GET and use CSRF tokens to avoid CSRF attacks

@tardoe
Copy link
Author

tardoe commented Jul 14, 2021

@nickhilliard @barryo is it worth me fixing the conflicts above and making this implementation work against the new ORM?

What’s the priority on this feature?

@barryo
Copy link
Member

barryo commented Jul 15, 2021

I wouldn't just now @tardoe - let's keep this open and @yannrobin and I will review and look to implement this or something like it now that we have v6 out the door. Give us a couple weeks to catch up.

@tardoe
Copy link
Author

tardoe commented Feb 24, 2022

@barryo @yannrobin Can I get an update on this? I know of at least 3 IXs running custom forks just to have this feature - it makes upgrading for the communal features infinitely harder for them. If you don't have the resources to complete the required changes, please advise me and I can put the time into it.

@shaneshort
Copy link

bump, any reason this hasn't been merged? @barryo @nickhilliard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for port-specific VLAN tags
3 participants