-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream generators #158
Draft
skryukov
wants to merge
9
commits into
inertiajs:master
Choose a base branch
from
skryukov:upstream-generators
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Upstream generators #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is amazing, I'd really like to use the typescript scaffolds you've created. Do you need any assistance in getting this PR ready for review? |
@jacobmichels thanks for the ping! I hope to finish this PR in couple days, my current goal is to implement a simple smoke test that will generate new Rails app, install inertia, generate some scaffolds and run system tests. |
skryukov
force-pushed
the
upstream-generators
branch
3 times, most recently
from
November 20, 2024 20:03
29ae34f
to
510eb95
Compare
skryukov
force-pushed
the
upstream-generators
branch
3 times, most recently
from
November 21, 2024 11:15
7084f9a
to
ddfc607
Compare
skryukov
force-pushed
the
upstream-generators
branch
from
November 21, 2024 13:03
ddfc607
to
e1ddcf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upstreams generators from https://github.com/skryukov/inertia_rails-contrib
TODO: