Add QuestDB Tool to Kindling #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-griffith
requested changes
Sep 22, 2025
There was a problem hiding this comment.
- Standing up an entire QuestDB instance is very heavy by comparison to SQLite. I suspect there's a lot of optimization we can do to that startup, since this will only ever be a read only copy. In particular, an entire webserver complete with its own configuration GUI, plus many worker threads, seems like a crazy hit. I'd like us to start very small with how much QuestDB we're surfacing via Kindling.
2. We need to either reflow the 'main' panel to account for this extra tool (3 - 4 - 3? something else?), or put QuestDB into the same 'tool' as SQLite and figure out a way to layer them on top of each other we don't hate down the road. This basic configuration view works great for now, but in the future we may want more bespoke views for history (and auditing, and alarm journal) data that's all in Quest, much like there are different 'overlays' for SQLite IDB files.
- You've also got some (minor) style faults
|
|
||
| val httpPort = ServerSocket(0).use { it.localPort } // web console port | ||
| val config = """ | ||
| pg.net.bind.to=0.0.0.0:$pgPort |
There was a problem hiding this comment.
Should be localhost, not 0.0.0.0, most likely, so we're not inadvertently exposing a questdb instance to the entire network
|
|
||
| @Suppress("SqlResolve") | ||
| val tables: List<Table> = connection | ||
| .executeQuery("""SELECT table_name FROM tables();""") |
There was a problem hiding this comment.
Nit: Doesn't need to be a triple quoted string
| ) | ||
| } | ||
| val size: Long | ||
| connection.executeQuery("""SELECT diskSize FROM table_storage() WHERE tableName = '$tableName'""").use { rs -> |
There was a problem hiding this comment.
Nit: Doesn't need to be a triple quoted string
Or, if it is, might as well format the SQL query nicer
| val size: Long | ||
| connection.executeQuery("""SELECT diskSize FROM table_storage() WHERE tableName = '$tableName'""").use { rs -> | ||
| // Move the cursor to the first row. If there's no row, default to 0. | ||
| size = if (rs.next()) rs.getLong("diskSize") else 0L |
There was a problem hiding this comment.
You could collapse this to a single expression - val size = connection.executeQuery().use { rs.getLong() else 0L}
| size = size, | ||
| ) | ||
| } catch (e: Exception) { | ||
| println("Warning: Could not process table '$tableName'. Error: ${e.message}") |
| val value = resultSet.getObject(i + 1) | ||
| when { | ||
| types[i] == Boolean::class.javaObjectType -> value == 1 | ||
| types[i] == Date::class.java && value is Number -> Date(value.toLong()) |
There was a problem hiding this comment.
Are these sqlite-based datatype hacks still actually needed for quest?
| resultSet.metaData.getColumnName(i + 1) | ||
| } | ||
| val types = List(columnCount) { i -> | ||
| val isTimestamp = names[i].containsInOrder("tsmp", true) |
There was a problem hiding this comment.
Same with this isTimestamp stuff - makes sense for generic sqlite view, probably not needed for quest
|
@paul-griffith Ready for review again.
|
…estdb historian directory. The tool provides a table that shows tables to query, and a secondary paginated table for efficient querying over large exports.
…rtableTree component from the .idb tool.
paul-griffith
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a QuestDB Viewer tool to Kinding which takes a .zip export of a historian folder, and opens the export similar to the .idb viewer DB tool. Also includes refactor to move common components used in the .idb and quest tools to core.