Prevent returning 401 for other successful OAuth2 plugins #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure this is fixed yet. I can currently connect with the Enable Mastodon Apps plugin however if I enable the updated IndieAuth plugin (v4.4.2) I'm unable to connect with Mastodon apps (Fedilab, Phanpy, etc). If I deactivate the IndieAuth plugin I'm able to connect with the apps again. |
|
@akirk Are you still taking the lead on diagnosing the plugin interaction? |
|
Yes, I'm on it and released https://github.com/akirk/enable-mastodon-apps/releases/tag/0.6.4 to address this. |
Great. Sorry about the conflict... I thought we got it last time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes akirk/enable-mastodon-apps#43
IndieAuth interferes with the Enable Mastodon Apps plugin when it successfully authenticates the user. This is a follow up to #245 where we checked for a successful authentication but the REST response is still
{"error":"invalid_token","error_description":"Invalid access token"}coming from therest_authentication_errorshook.