Fix deprecation notice #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed another one, I think the |
|
It wouldn't.. that it me thinking about generating slugs for post titles...which this isn't. Actually working on a bunch of cleanup for this plugin right now...so anything you see can get rolled up into the 4.4 release I'm planning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rawurldecode()does not or no longer (I'm on PHP 8.1 right now) acceptnullas a first param. As such, a deprecation warning occasionally pops up in WordPress' debug log (if it happens to be enabled, of course).By setting it to an empty string instead, this is notice no longer appears.
Also, later on
wp_login_url( $redirect_to )is run; I checked the documentation forwp_login_url()and found that the default value for its first argument is an empty string, and that it actually expects a string. I.e., I think a string is okay. :-)