Conversation
duartegalvao
force-pushed
the
affiliations
branch
2 times, most recently
from
5227390 to
2c79285
Compare
duartegalvao
force-pushed
the
affiliations
branch
10 times, most recently
from
b89aaec to
7aa56af
Compare
duartegalvao
force-pushed
the
affiliations
branch
from
7aa56af to
7b2cea7
Compare
| } | ||
|
|
||
| return ( | ||
| <div styleName="items-column-container"> |
There was a problem hiding this comment.
I guess that the Semantic UI Table component doesn't look good here (or it doesn't fit altogether)?
There was a problem hiding this comment.
why a table for a tags display? inside of another table no less 😄
There was a problem hiding this comment.
If we had alread the datatable widget in Indico, we could avoid ALL of this filtering logic. 😮💨🌈
duartegalvao
force-pushed
the
affiliations
branch
4 times, most recently
from
e4fb5dc to
5d7cba6
Compare
duartegalvao
changed the title
duartegalvao
force-pushed
the
affiliations
branch
from
5d7cba6 to
c0fe39d
Compare
duartegalvao
force-pushed
the
affiliations
branch
4 times, most recently
from
84426f1 to
860a914
Compare
|
@ThiefMaster I believe this is ready to be merged. We've been using it in prod for a few weeks now and it seems to be stable enough! Let me know if you need anything else before merging |
|
Great, I'll have a look during the next few days (not sure whether that's before or after the long Easter weekend though) |
| @@ -0,0 +1,10 @@ | |||
| // This file is part of the third-party Indico plugins. | |||
| // Copyright (C) 2026 CERN | |||
There was a problem hiding this comment.
Feel free to add your own .header.yml in the plugin that sets a different owner to be added in the header.
There was a problem hiding this comment.
Also please rebase, I just fixed the headers of the existing files in the repo so these changes don't have to be part of your PR.
There was a problem hiding this comment.
it's quite important for us that CERN owns the copyright of this plugin... Is that ok with you?
There was a problem hiding this comment.
ok, if you don't need credits there I don't think there's any issue with that on our side
Something like "CERN and contributors" could also work but not sure if that's a good idea
duartegalvao
force-pushed
the
affiliations
branch
2 times, most recently
from
5464d68 to
640625f
Compare
duartegalvao
force-pushed
the
affiliations
branch
from
640625f to
ed8fb4e
Compare
4 participants
This PR adds the Extended Affiliations plugin.
Currently set to draft while we are performing our own reviews, but it is fully functional.