MODHAADM-105: Unhandled exception when reading PURGE_LOGS_AFTER #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://folio-org.atlassian.net/browse/MODHAADM-105 Parsing the response may fail when doing "new JsonObject(response)", "getJsonArray" or "getJsonObject". The parse error is not handled because the code is in "onSuccess(", therefor the request hangs forever. Fix: Use map, not onSuccess. Avoid Promise that almost always is wrong and can be replaced with Future returning calls. In addition fix CQL and percent encoding.
|
Obsoleted by #126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/MODHAADM-105
Parsing the response may fail when doing "new JsonObject(response)", "getJsonArray" or "getJsonObject".
The parse error is not handled because the code is in "onSuccess(", therefor the request hangs forever.
Fix:
Use map, not onSuccess.
Avoid Promise that almost always is wrong and can be replaced with Future returning calls.
In addition fix CQL and percent encoding.