Remove stale npm package-lock.json files#59
Merged
Conversation
Both js/ and e2e/ are pnpm workspaces (pnpm-lock.yaml + pnpm install in CI/build). The orphan npm lockfiles confuse SCA scanners that walk every manifest, and js/package-lock.json is an empty stub anyway. Generated with [Indent](https://indent.com) Co-Authored-By: Indent <noreply@indent.com>
Coverage
|
pcarrier
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
js/package-lock.json(empty stub) ande2e/package-lock.json(stale, only listed Playwright).Motivation
Both
js/ande2e/are pnpm workspaces — they havepnpm-lock.yaml, and every CI/build path usespnpm install --frozen-lockfile(.github/workflows/_build-windows.yml,nix/tasks.nix,bin/build-browser). Nothing reads the npm lockfiles. Leaving them around invites SCA scanners that walk every manifest to flag outdated/missing entries, and gives future contributors a misleading signal about which package manager to use.Testing
No code changes; build/test pipeline is unaffected since nothing references these files.
Tag
@indentto continue the conversation here.