IWF-363: Support dynamic internal channel by prefix MVP version #47
Conversation
longquanzheng
changed the title
longquanzheng
requested review from
mixydubs,
stevo89519,
ktrops,
samuel27m and
lwolczynski
| communication.publish_to_internal_channel( | ||
| test_channel_name_prefix + "abc", "str-value-for-prefix" | ||
| ) |
There was a problem hiding this comment.
this confused me a bit, but it looks like we're using this WaitAnyWithPublishState state to write to the prefix internal channel and nothing else happens in WaitAnyWithPublishState for the prefix internal channel? But our WaitAllThenPublishState will see the write to the test-internal-channel-prefix-abc channel and have it's for_all_command_completed check satisfied?
There was a problem hiding this comment.
You are right on the test workflow behavior.
This test is a bit crazy to test multiple things together. The initState basically goes to two states in parallel: WaitAnyWithPublishState and WaitAllThenPublishState.
WaitAllThenPublishState will start with waiting, and publishing on execute. WaitAnyWithPublishState will start with publishing+waiting, and then execute.
that way we can test the publshing on both waitUntil/execute, any/all waitingTypes etc.
Co-authored-by: Samuel Caçador <[email protected]>
* IWF-356: Add atomic checking decision for channels * DONE * DONE * DONE * DONE * Fix mypy * Fix bug * fix env * fix import * IWF-363: Support dynamic internal channel by prefix MVP version (#47) * Support dynamic internal channel by prefix * fix ignore * Update iwf/command_results.py Co-authored-by: Samuel Caçador <[email protected]> --------- Co-authored-by: Samuel Caçador <[email protected]> --------- Co-authored-by: Samuel Caçador <[email protected]>
No description provided.