Update packages

inc2734 · Mar 16, 2024 · f45a85b · f45a85b
1 parent 9cc050c
commit f45a85b
Show file tree

Hide file tree

Showing 39 changed files with 4,681 additions and 3,608 deletions.
diff --git a/.editorconfig b/.editorconfig
@@ -1,21 +1,21 @@
+# This file is for unifying the coding style for different editors and IDEs
+# editorconfig.org
+
+# WordPress Coding Standards
+# https://make.wordpress.org/core/handbook/coding-standards/
+
 root = true
 
 [*]
-indent_style = space
-indent_size = 2
-end_of_line = lf
 charset = utf-8
-trim_trailing_whitespace = true
+end_of_line = lf
 insert_final_newline = true
+trim_trailing_whitespace = true
+indent_style = tab
 
-[*.md]
-trim_trailing_whitespace = false
-
-[*.{json, yml}]
+[*.yml]
+indent_style = space
 indent_size = 2
 
-[*.php]
-indent_style = tab
-
-[*.js]
-indent_style = tab
+[*.md]
+trim_trailing_whitespace = false
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -18,10 +18,10 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
 
     - name: Cache node modules
-      uses: actions/cache@v2
+      uses: actions/cache@v4
       env:
         cache-name: cache-node-modules
       with:
@@ -33,20 +33,20 @@ jobs:
           ${{ runner.os }}-node-
           ${{ runner.os }}-
 
-    - name: Use Node.js 12.x
-      uses: actions/setup-node@v1
+    - name: Use Node.js
+      uses: actions/setup-node@v4
       with:
-        node-version: 12.x
+        node-version-file: 'package.json'
 
     - name: Npm install
-      run: npm install
+      run: npm ci
 
     - name: Get Composer Cache Directory
       id: composer-cache
-      run: echo "::set-output name=dir::$(composer config cache-files-dir)"
+      run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
 
     - name: Cache vendor
-      uses: actions/cache@v2
+      uses: actions/cache@v4
       with:
         path: ${{ steps.composer-cache.outputs.dir }}
         key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -12,10 +12,10 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
 
     - name: Cache node modules
-      uses: actions/cache@v2
+      uses: actions/cache@v4
       env:
         cache-name: cache-node-modules
       with:
@@ -27,20 +27,20 @@ jobs:
           ${{ runner.os }}-build-
           ${{ runner.os }}-
 
-    - name: Use Node.js 12.x
-      uses: actions/setup-node@v1
+    - name: Use Node.js
+      uses: actions/setup-node@v4
       with:
-        node-version: 12.x
+        node-version-file: 'package.json'
 
     - name: Npm install
-      run: npm install
+      run: npm ci
 
     - name: Get Composer Cache Directory
       id: composer-cache
-      run: echo "::set-output name=dir::$(composer config cache-files-dir)"
+      run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
 
     - name: Cache vendor
-      uses: actions/cache@v2
+      uses: actions/cache@v4
       with:
         path: ${{ steps.composer-cache.outputs.dir }}
         key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
@@ -63,7 +63,7 @@ jobs:
       with:
         tag_name: ${{ github.ref }}
         release_name: ${{ github.ref }}
-        draft: false
+        draft: true
         prerelease: false
 
     - name: Upload Release Asset
@@ -76,3 +76,10 @@ jobs:
         asset_path: ./smart-custom-fields.zip
         asset_name: smart-custom-fields.zip
         asset_content_type: application/zip
+
+    - name: Upload to github release
+      uses: eregon/publish-release@v1
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      with:
+        release_id: ${{ steps.create_release.outputs.id }}
diff --git a/.gitignore b/.gitignore
@@ -7,3 +7,4 @@ node_modules/
 /.export/*
 smart-custom-fields/
 smart-custom-fields.zip
+.phpunit.result.cache
diff --git a/.phpcs.xml.dist b/.phpcs.xml.dist
@@ -1,46 +1,112 @@
 <?xml version="1.0"?>
-<ruleset name="WordPress Coding Standards">
-	<description>Sniffs for WordPress plugins, with minor modifications</description>
-
-	<rule ref="PHPCompatibility"/>
-	<config name="testVersion" value="5.6-"/>
-
-	<rule ref="WordPress-Core">
-    <exclude name="Generic.Arrays.DisallowShortArraySyntax.Found"/>
-    <exclude name="Generic.Commenting.DocComment.MissingShort"/>
-    <exclude name="Generic.Commenting.DocComment.ShortNotCapital"/>
-    <exclude name="WordPress.Files.FileName.InvalidClassFileName"/>
-    <exclude name="Squiz.Commenting.ClassComment.Missing"/>
-    <exclude name="Squiz.Commenting.InlineComment.InvalidEndChar"/>
-    <exclude name="Squiz.Commenting.FileComment.SpacingAfterComment"/>
-    <exclude name="WordPress.Files.FileName.NotHyphenatedLowercase"/>
-    <exclude name="WordPress.NamingConventions.ValidHookName.UseUnderscores"/>
-  </rule>
-	<rule ref="WordPress-Docs"/>
-	<rule ref="WordPress.WP.I18n"/>
+<ruleset name="plugins">
+	<description>Apply WordPress Coding Standards to all files</description>
+
+	<!-- Only scan PHP files. -->
+	<arg name="extensions" value="php"/>
+
+	<!-- Whenever possible, cache the scan results and re-use those for unchanged files on the next scan. -->
+	<arg name="cache"/>
+
+	<!-- Set the memory limit to 256M.
+		 For most standard PHP configurations, this means the memory limit will temporarily be raised.
+		 Ref: https://github.com/squizlabs/PHP_CodeSniffer/wiki/Advanced-Usage#specifying-phpini-settings
+	-->
+	<ini name="memory_limit" value="256M"/>
+
+	<!-- Strip the filepaths down to the relevant bit. -->
+	<arg name="basepath" value="./"/>
+
+	<!-- Check up to 20 files simultaneously. -->
+	<arg name="parallel" value="20"/>
+
+	<!-- Show sniff codes in all reports. -->
+	<arg value="sp"/>
+
+	<arg name="colors"/>
+
+	<!-- Rules: Check PHP version compatibility -->
+	<!-- https://github.com/PHPCompatibility/PHPCompatibility#sniffing-your-code-for-compatibility-with-specific-php-versions -->
+	<config name="testVersion" value="7.4-"/>
+	<rule ref="PHPCompatibilityWP">
+		<include-pattern>*\.php</include-pattern>
+	</rule>
+	<config name="minimum_wp_version" value="6.4"/>
+
 	<config name="text_domain" value="smart-custom-fields"/>
 
-	<rule ref="VariableAnalysis.CodeAnalysis.VariableAnalysis">
+	<rule ref="WordPress"/>
+	<rule ref="WordPress.NamingConventions.PrefixAllGlobals">
 		<properties>
-			<property name="allowUnusedParametersBeforeUsed" value="true"/>
+			<!-- Value: replace the function, class, and variable prefixes used. Separate multiple prefixes with a comma. -->
+			<property name="prefixes" type="array" value="usmart-custom-fields"/>
 		</properties>
 	</rule>
-	<rule ref="WordPress.CodeAnalysis.EmptyStatement"/>
-
-	<rule ref="PEAR.Functions.FunctionCallSignature">
+	<rule ref="WordPress.WP.I18n">
 		<properties>
-			<property name="allowMultipleArguments" value="false"/>
+			<!-- Value: replace the text domain used. -->
+			<property name="text_domain" type="array" value="smart-custom-fields"/>
+		</properties>
+	</rule>
+	<rule ref="WordPress.WhiteSpace.ControlStructureSpacing">
+		<properties>
+			<property name="blank_line_check" value="true"/>
 		</properties>
 	</rule>
 
-	<arg value="ps"/>
-	<arg name="extensions" value="php"/>
+	<rule ref="WordPress.DB.SlowDBQuery.slow_db_query_tax_query">
+		<exclude-pattern>*</exclude-pattern>
+	</rule>
+	<rule ref="WordPress.Files.FileName">
+		<exclude-pattern>*</exclude-pattern>
+	</rule>
+	<rule ref="WordPress.NamingConventions.PrefixAllGlobals">
+		<exclude-pattern>*</exclude-pattern>
+	</rule>
+	<rule ref="WordPress.NamingConventions.ValidVariableName.VariableNotSnakeCase">
+		<exclude-pattern>*</exclude-pattern>
+	</rule>
+	<rule ref="WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase">
+		<exclude-pattern>*</exclude-pattern>
+	</rule>
+	<rule ref="WordPress.NamingConventions.ValidVariableName.PropertyNotSnakeCase">
+		<exclude-pattern>*</exclude-pattern>
+	</rule>
+	<rule ref="WordPress.NamingConventions.ValidHookName.UseUnderscores">
+		<exclude-pattern>*</exclude-pattern>
+	</rule>
+	<rule ref="Generic.Commenting.DocComment.MissingShort">
+		<exclude-pattern>*</exclude-pattern>
+	</rule>
+	<rule ref="Squiz.Commenting.ClassComment">
+		<exclude-pattern>*</exclude-pattern>
+	</rule>
+	<rule ref="Squiz.Commenting.FileComment.WrongStyle">
+		<exclude-pattern>*</exclude-pattern>
+	</rule>
+	<rule ref="Squiz.Commenting.FileComment.Missing">
+		<exclude-pattern>*</exclude-pattern>
+	</rule>
+	<rule ref="Squiz.Commenting.FileComment.MissingPackageTag">
+		<exclude-pattern>*</exclude-pattern>
+	</rule>
+	<rule ref="Squiz.Commenting.FileComment.SpacingAfterComment">
+		<exclude-pattern>*</exclude-pattern>
+	</rule>
+	<rule ref="Squiz.Commenting.InlineComment.InvalidEndChar">
+		<exclude-pattern>*</exclude-pattern>
+	</rule>
+	<rule ref="PSR2.Methods.MethodDeclaration.Underscore">
+		<exclude-pattern>*</exclude-pattern>
+	</rule>
+
 
+	<!-- What to scan -->
 	<file>.</file>
-	<exclude-pattern>/vendor/</exclude-pattern>
-	<exclude-pattern>/node_modules/</exclude-pattern>
+	<exclude-pattern>/vendor/*</exclude-pattern>
+	<exclude-pattern>/node_modules/*</exclude-pattern>
 	<exclude-pattern>/.export/*</exclude-pattern>
-  <exclude-pattern>*/tests/*</exclude-pattern>
-  <exclude-pattern>*/languages/*</exclude-pattern>
-  <exclude-pattern>*/dist/*</exclude-pattern>
+	<exclude-pattern>/bin/*</exclude-pattern>
+	<exclude-pattern>/dist/*</exclude-pattern>
+	<exclude-pattern>/languages/*</exclude-pattern>
 </ruleset>
diff --git a/classes/class.config.php b/classes/class.config.php
@@ -10,12 +10,12 @@
  */
 class SCF_Config {
 	/**
-	 * name
+	 * The key name of this plugin.
 	 */
 	const NAME = 'smart-custom-fields';
 
 	/**
-	 * prefix
+	 * The prefix of this plugin.
 	 */
 	const PREFIX = 'smart-cf-';
 

diff --git a/classes/class.rest-api.php b/classes/class.rest-api.php
@@ -34,7 +34,7 @@ public function register_rest_api_routes() {
 			array(
 				'methods'             => 'GET',
 				'callback'            => array( $this, 'get_all_posts' ),
-				'permission_callback' => function() {
+				'permission_callback' => function () {
 					return current_user_can( 'edit_posts' );
 				},
 			)