Skip to content

estimate densities from point patterns #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 813 commits into
base: master
Choose a base branch
from
Open

estimate densities from point patterns #27

wants to merge 813 commits into from

Conversation

ThierryO
Copy link
Member

@stijnvanhoey can you render this? I can't render the SQL tutorial.

@ThierryO ThierryO requested a review from stijnvanhoey June 28, 2017 12:54
@florisvdh florisvdh mentioned this pull request Jun 23, 2020
Closed
@florisvdh
Copy link
Member

Some work to get this tutorial in the right directory structure has been done in the density_fv branch. Fixing CRS specification will folllow later.

@florisvdh florisvdh mentioned this pull request Sep 16, 2020
Merged
florisvdh
florisvdh reviewed Sep 23, 2020
View reviewed changes
Copy link
Member

@florisvdh florisvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThierryO In PR #195 I suggest some changes to get in line with the current tutorials (folder setup, CRS).

Please note:

  • index.md is still to be regenerated - reason: see next point. YAML header in Rmd has been updated already in 'estimate densities from point patterns': PROJ>=6 compliance #195 .
  • the ggmap code with google map will need to be revised. Current code cannot be run (hence, index.md cannot be updated) except when getting a personal API from google and handing your credit card details (and it's free just for a limited period). Not fit for a tutorial anymore IMHO. Maybe you will now rather prefer using OSM.

@florisvdh
Copy link
Member

@ThierryO In PR #195 I suggest some changes to get in line with the current tutorials (folder setup, CRS).

Please note:

  • index.md is still to be regenerated - reason: see next point. YAML header in Rmd has been updated already in 'estimate densities from point patterns': PROJ>=6 compliance #195 .

  • the ggmap code with google map will need to be revised. Current code cannot be run (hence, index.md cannot be updated) except when getting a personal API from google and handing your credit card details (and it's free just for a limited period). Not fit for a tutorial anymore IMHO. Maybe you will now rather prefer using OSM.

Follow-up: PR #195 has now been merged into this PR. @ThierryO the above notes still need some work before it can be merged in master and this long-standing but nice tutorial will be merged.

@ThierryO
Copy link
Member Author

Sorry. This has very low priority to me. Feel free to update the code.

@florisvdh
Copy link
Member

@inbo/bmk

florisvdh and others added 22 commits May 4, 2022 16:48
@florisvdh
Merge pull request #306 from inbo/pr_template
29bf515 
Update PR template
@hansvancalster @florisvdh
Apply suggestions from code review
a4f72c9 
Co-authored-by: Floris Vanderhaeghe <[email protected]>
@hansvancalster
relative weblinks
18938ec
@hansvancalster
open source TOTP tools
f2aac02
@hansvancalster
drop sentence about HTTP
277b9f8
@hansvancalster
fix anchor links
918729b
@hansvancalster
remove faulty claim about GitHub's default
29870b0
@hansvancalster
update md file
85cecd3
@hansvancalster
fix section cross-references
c8417de
@hansvancalster
redundant chunk options
0872e22
@hansvancalster
add backticks
11a7fb7
@hansvancalster
remove vaccinate instructions
ff93de0
@hansvancalster
update md
3660bb8
@hansvancalster
check global config settings
291fc24
@hansvancalster
project-specific gitignore file from checklist
095c785
@hansvancalster
update md
9896443
@hansvancalster
update title to mention GitHub
c99d23d 
- 2FA = about GitHub authentication
@hansvancalster
clarifications about 2FA
4354873
@hansvancalster
move sentence to more logical place
91659f7
@hansvancalster
foolproofing...;-)
5aa3e93
@ThierryO
bugfix in RProfile.site
31a7ef0
@ThierryO
Merge pull request #312 from inbo/hotfix
d12bc14 
bugfix in RProfile.site
falkmielke and others added 29 commits November 26, 2024 11:45
@falkmielke
brms-rstan: re-organize static files
4f731a9
@falkmielke
brms-rstan: knit files; image issues
75efd94
@PietrH
Switch to using artifacts v4
9b93611 
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
@damianooldoni
Merge pull request #350 from inbo/349-switch-to-artifacts-v4
316e518 
Switch to using artifacts v4
@florisvdh
r_database_access: update argument of dbConnect()
a3556f5
@florisvdh
Merge pull request #351 from inbo/database_access
fde1619 
r_database_access: update argument of dbConnect()
@falkmielke
Merge pull request #346 from inbo/rstan
8c46fb7 
BRMS tutorial: add `rstan` example
@ThierryO
fix url
643b62b
@ThierryO
Merge pull request #354 from inbo/inbomd
0d91d27 
fix url
@florisvdh
Update pull_request_template.md
f983c76 
While reviewing #356, the instructions of the PR template for reviewing seem to no longer work to render the site from the GHA artifact.

With these changes, it seems to work again though, using python -m http.server 8887
@falkmielke
update_pr_template: introduce
2f67cb9
@falkmielke
update_pr_template: *cf.* consistency
8060599 
Latijns -> italics; https://nl.wikipedia.org/wiki/Cf.
@falkmielke
update_pr_template: proofread "create tutorial"
d9a9724
@falkmielke
update_pr_template: refresh pr template
0698666
@falkmielke
update_pr_template: additional suggestions*
5bf6856 
by @florisvdh, #357
@florisvdh
Merge pull request #357 from inbo/update_pr_template
4608880 
Update pull_request_template.md
@ThierryO @falkmielke
add rmd file on estimating densities from point patterns
6d7631a
@florisvdh @falkmielke
point-pattern: move files in correct location
ba66028
@florisvdh @falkmielke
point-pattern: rename Rmd
98f0c5a
@florisvdh @falkmielke
spatial_point_pattern: underscores in folder
424eadf
@florisvdh @falkmielke
spatial_point_pattern: add gfm md_document outputformat in YAML
1d07b8a
@florisvdh @falkmielke
spatial_point_pattern: use PROJ>=6 compliant CRS
9e2ae59
@florisvdh @falkmielke
spatial_point_pattern: use proj4string<- function rather than the slot *
34ef686 
The use of 'proj4string' in R code is confusing in times where PROJ.4 strings are obsoleted.
It can be expected that a more general function name to set an object's CRS will sooner or later
be promoted instead of proj4string<-, hence preparing for that already by using the function instead of the slot.
I expect the proj4string slot will most probably remain in use for compatibility reasons, but
explicitly naming it is better avoided in times where WKT2 strings are actually used to define a CRS.
@florisvdh @falkmielke
spatial_point_pattern: expand on CRS/proj4string/WKT2
70c5660
@florisvdh @falkmielke
spatial_point_pattern: improve markdown & language
dc8572f
@peterdesmet @falkmielke
Use frontmatter used elsewhere
b714e11 
See #285
@falkmielke
density: remove ancient _site.yml
dafed22
@falkmielke
density: revival
19ea897
@falkmielke
density: rebase / merge conflicts
18aad03
@falkmielke
Copy link
Contributor

Sorry for necro-bumping...
I rebased this branch and added an updated little tutorial to calculate point density.

Feel free to add/comment/wrap up and merge @ThierryO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florisvdh florisvdh florisvdh left review comments

@stijnvanhoey stijnvanhoey Awaiting requested review from stijnvanhoey

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.