-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use maps as opts (and other small cosmetic changes) #207
Conversation
65b5ba2
to
ed95e10
Compare
ed95e10
to
30fa495
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent contribution, as usual, @NelsonVides !!!
I'll give @paulo-ferraz-oliveira a day or two to review it and merge it. If he has not requested changes by Monday, I'll merge it and generate a new release with these changes. |
https://hex.pm/packages/worker_pool/6.3.0 … but… I could not publish the docs to hex because… ===> Running ex_doc for worker_pool
===> ERROR! Failed to start Elixir.
error: {error,
{elixir,
{bad_return,
{{elixir,start,[normal,[]]},
{'EXIT',
{undef,
[{elixir,start,[normal,[]],[]},
{application_master,start_it_old,4,
[{file,"application_master.erl"},
{line,295}]}]}}}}}}
===> And I don't have time to debug this on my machine. |
Hmm... maybe something about versions? Updating the hex package or so? 🤔 |
You can try adding me to hex and I'll see if I can publish docs |
Far too often I already have the opts for a pool created as a map and then I have to do
maps:to_list/1
. I think maps are just way too ubiquitous these days, it's a pity not to support them 😄There are other cosmetic changes, like improving typespecs, upgrading plugin versions, using fully-qualified MFAs (the efficiency guide says they're somewhat faster function calls), and, increasing test coverage 🙂