Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maps as opts (and other small cosmetic changes) #207

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

NelsonVides
Copy link
Collaborator

Far too often I already have the opts for a pool created as a map and then I have to do maps:to_list/1. I think maps are just way too ubiquitous these days, it's a pity not to support them 😄

There are other cosmetic changes, like improving typespecs, upgrading plugin versions, using fully-qualified MFAs (the efficiency guide says they're somewhat faster function calls), and, increasing test coverage 🙂

Copy link
Member

@elbrujohalcon elbrujohalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent contribution, as usual, @NelsonVides !!!

@elbrujohalcon
Copy link
Member

I'll give @paulo-ferraz-oliveira a day or two to review it and merge it. If he has not requested changes by Monday, I'll merge it and generate a new release with these changes.

@elbrujohalcon elbrujohalcon merged commit b34a0db into main Aug 26, 2024
1 check passed
@elbrujohalcon elbrujohalcon deleted the use_maps_as_opts branch August 26, 2024 16:37
@elbrujohalcon
Copy link
Member

https://hex.pm/packages/worker_pool/6.3.0 … but… I could not publish the docs to hex because…

===> Running ex_doc for worker_pool
===> ERROR! Failed to start Elixir.
error: {error,
           {elixir,
               {bad_return,
                   {{elixir,start,[normal,[]]},
                    {'EXIT',
                        {undef,
                            [{elixir,start,[normal,[]],[]},
                             {application_master,start_it_old,4,
                                 [{file,"application_master.erl"},
                                  {line,295}]}]}}}}}}

===>

And I don't have time to debug this on my machine.

@NelsonVides
Copy link
Collaborator Author

https://hex.pm/packages/worker_pool/6.3.0 … but… I could not publish the docs to hex because…

===> Running ex_doc for worker_pool
===> ERROR! Failed to start Elixir.
error: {error,
           {elixir,
               {bad_return,
                   {{elixir,start,[normal,[]]},
                    {'EXIT',
                        {undef,
                            [{elixir,start,[normal,[]],[]},
                             {application_master,start_it_old,4,
                                 [{file,"application_master.erl"},
                                  {line,295}]}]}}}}}}

===>

And I don't have time to debug this on my machine.

Hmm... maybe something about versions? Updating the hex package or so? 🤔

@NelsonVides
Copy link
Collaborator Author

You can try adding me to hex and I'll see if I can publish docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants