Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for rich_text blocks #107

Merged
merged 11 commits into from
Jan 13, 2024
Merged

Conversation

parente
Copy link
Contributor

@parente parente commented Jan 8, 2024

The documentation for rich text elements is very limited. I used this block kit playpen to explore the schema of each element, and constraints on their children and attribute values.

  • RichText block
  • RichTextList element
  • RichTextPreformatted element
  • RichTextQuote element
  • RichTextSection element
  • Emoji object
  • Text object
  • Style object (name overlap with enum.Style, should naming deviate and use be TextStyle?)

@parente parente changed the title WIP: Implement support for rich_text blocks Implement support for rich_text blocks Jan 9, 2024
@parente parente marked this pull request as ready for review January 9, 2024 04:15
@parente
Copy link
Contributor Author

parente commented Jan 9, 2024

@imryche I've added the objects, elements, and block classes needed for rich text support in this pull request. It's already quite long so I stopped before diving into the generator aspects. I think those might be better in a second PR. What do you think?

@imryche
Copy link
Owner

imryche commented Jan 13, 2024

@parente Thank you for the substantial work you've put into this. Yeah, the generator part is definitely could wait and is less critical at this stage.

@imryche imryche merged commit e65a95a into imryche:master Jan 13, 2024
5 checks passed
@parente
Copy link
Contributor Author

parente commented Jan 13, 2024

Thanks for creating and maintaining this library, @imryche.

I might try my hand at the generator PR as well. But as before, don't let me block you if you want to have at it.

@parente parente deleted the rich_text branch January 23, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants