Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10/use better app import format #49

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
7bf87ba
WIP: Enable import with format <path.to.module>[:path.to.object]
imranariffin Oct 31, 2022
5cb18fd
WIP
imranariffin Nov 18, 2022
5bb9b4c
Fixup
imranariffin Nov 19, 2022
82e56da
Move out sample_apps to its own package: Passed tests
imranariffin Nov 19, 2022
74f6d7a
Move sample_apps under root/src: Passed tests
imranariffin Nov 19, 2022
6ad6723
Ignore sample_apps/pyproject.toml, commited by mistake
imranariffin Nov 19, 2022
acd2abd
Add README.md for sample_apps
imranariffin Nov 19, 2022
f16433b
Add link from README.md to src/sample_apps/README.md
imranariffin Nov 19, 2022
6ee7ae1
Update VS code extra_paths to include src/sample_apps/
imranariffin Nov 19, 2022
b186c68
Fixup
imranariffin Nov 19, 2022
072956c
Delint & fix broken black
imranariffin Nov 19, 2022
7075bca
Fix vscode launch.json
imranariffin Nov 19, 2022
838821e
Pass Case 1 & 2
imranariffin Nov 20, 2022
ba0050b
Cover all import cases
imranariffin Nov 21, 2022
66bca53
WIP: Move sample_apps/ to outside of src/; 1 failed test
imranariffin Nov 21, 2022
c620840
Revert "WIP: Move sample_apps/ to outside of src/; 1 failed test"
imranariffin Nov 21, 2022
fa47715
Move tests & sample_apps to src/ [Pass tests]
imranariffin Nov 21, 2022
7274fcd
Run pylint separately for sample_apps; FAILED
imranariffin Nov 21, 2022
0377781
Remove unnecessary test import cases
imranariffin Nov 21, 2022
3901abb
Fixup
imranariffin Nov 22, 2022
7d1066f
Add test to ensure parity with Celery: All tests PASSED
imranariffin Nov 22, 2022
c286786
Cleanup
imranariffin Nov 27, 2022
97cb83f
WIP: Ensure we test sample apps and sync with docs
imranariffin Nov 30, 2022
8841078
WIP
imranariffin Dec 10, 2022
ff991e9
W I P
imranariffin Dec 18, 2022
ee664e4
Fixup - Pass all tests
imranariffin Dec 18, 2022
2e34a0c
Fixup: demo scripts updated on sample_apps README
imranariffin Dec 18, 2022
a8d7463
Fixup
imranariffin Dec 18, 2022
b5ca716
Fixup
imranariffin Dec 18, 2022
7c05246
Fixup
imranariffin Dec 18, 2022
e1e2cd4
Fixup
imranariffin Dec 18, 2022
11fd695
Fixup
imranariffin Dec 18, 2022
ece97ac
Fixup tests
imranariffin Dec 18, 2022
88cbca6
Fixup tests
imranariffin Dec 18, 2022
a5e9023
Debug
imranariffin Dec 18, 2022
f82a768
Debug 2
imranariffin Dec 18, 2022
473eba2
Fixup
imranariffin Dec 18, 2022
1b277c5
Fixup
imranariffin Dec 18, 2022
5748993
Debug multiple jobs
imranariffin Dec 20, 2022
5daf10d
Revert "Debug multiple jobs"
imranariffin Dec 20, 2022
c1ff6c6
Debug check docs
imranariffin Dec 20, 2022
72520a1
Debug
imranariffin Dec 22, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,25 @@ on:
branches:
- main
jobs:
run_unit_tests:
tests:
timeout-minutes: 10
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- run: docker-compose -f ./docker-compose.yml up --detach redis
- uses: actions/setup-python@v3
with:
python-version: "3.10.x"
- run: source ./activate.sh
- run: pip install --upgrade pip
- run: pip install -e .[dev]
- run: pip freeze
- run: source test_prepare.sh
- run: ./test.sh

test_docs:
timeout-minutes: 3
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/setup-python@v3
with:
python-version: "3.10.x"
- run: ./demo-sample-apps-simple-app-aiotaskq.sh
- run: ./demo-sample-apps-simple-app-celery.sh
- run: ./check-docs.sh
7 changes: 4 additions & 3 deletions .github/workflows/coverage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@ jobs:
- uses: actions/setup-python@v3
with:
python-version: "3.10.x"
- run: source ./activate.sh
- run: pip install --upgrade pip
- run: pip install -e .[dev]
- run: ./env_create.sh ./src/tests/.venv/
- run: source ./env_activate.sh ./src/tests/.venv/
- run: ./install_dependencies.sh ./src/tests/
- run: python ./check_redis_ready.py
- run: pip freeze
- run: ./test.sh
- uses: codecov/[email protected]
4 changes: 0 additions & 4 deletions .github/workflows/pylint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,4 @@ jobs:
- uses: actions/setup-python@v3
with:
python-version: "3.10.x"
- run: source ./activate.sh
- run: pip install --upgrade pip
- run: pip install -e .[dev]
- run: pip freeze
- run: ./lint.sh
18 changes: 17 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -113,13 +113,26 @@ celerybeat.pid

# Environments
.env
.venv
.venv*
env/
venv/
ENV/
env.bak/
venv.bak/

# Sample Apps

src/*/.venv/
src/*/pyproject.toml
src/*/.Python
src/*/build/
src/*/develop-eggs/
src/*/dist/
src/*/eggs/
src/*/.eggs/
src/*/*.egg-info/
src/*/*.egg

# Spyder project settings
.spyderproject
.spyproject
Expand Down Expand Up @@ -152,3 +165,6 @@ cython_debug/
#.idea/

codecov

# NPM Scripts
node_modules/
Loading