Suggested fix for #551 #561
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggested fix for #551. I created a new type to handle the text array, and modified the generator to use this new type when the DB has a TEXT[] in the UDT.
Please let me know what you think of this change, and test it thoroughly. I tested it on my dev system, but it would be good to make sure that this change does not have wider impacts. My dev work was done in Windows, which this repo's build script does not support. I had to test on an internal fork with a build script that does work in windows, then copy the changes over into this branch. Please run tests and ensure everything works as expected, and verify that this indeed does fix the issue for you as well. I tested with my test repo for this issue: https://github.com/tlf30/pgjdbc-ng-test5.
It may be beneficial to add the datatypes for other arrays as well, as this issue may arise with more than just the TEXT datatype.
If this change is not to your liking, please close this PR.