-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: allow custom version #48
Conversation
WalkthroughThe changes introduce a refactoring across various components of the codebase to consistently use a single Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- crates/api_mastodon/src/entities/instance.rs (2 hunks)
- crates/nodeinfo/src/schema.rs (3 hunks)
- crates/utils/src/data.rs (2 hunks)
- crates/utils/src/lib.rs (1 hunks)
- crates/utils/src/version.rs (1 hunks)
Files skipped from review due to trivial changes (3)
- crates/nodeinfo/src/schema.rs
- crates/utils/src/data.rs
- crates/utils/src/version.rs
Additional comments not posted (4)
crates/utils/src/lib.rs (2)
6-6
: The addition of theversion
module enhances modularity by encapsulating version-related functionalities.
10-10
: Exporting theVERSION
constant publicly is a necessary change to facilitate its use across multiple crates.crates/api_mastodon/src/entities/instance.rs (2)
2-2
: The updated import statement correctly includes theVERSION
constant, aligning with the changes in the utility crate.
36-36
: Using theVERSION
constant fromhatsu_utils
for bothversion
anddescription
fields in theInstance
struct is a good practice, as it centralizes version management and improves maintainability.Also applies to: 42-42
Summary by CodeRabbit
New Features
VERSION
constant.Refactor
VERSION
constant for more consistent and maintainable code.