[PoC] Created FileEnumeratorIsh to demonstrate flat config support #2967
+236
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
force-pushed
the
file-enumerator-ish
branch
from
cb90bd1
to
9d677db
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending as a reference for #2829 -> eslint/eslint#18087.
This:
FileEnumerator.jsfrom ESLint's source as aFileEnumeratorIshclassFileEnumeratorIshinstead of the existingFileEnumeratorimports inno-unused-modules.jsThis code is not ready to be reviewed. It doesn't preserve existing licensing/ownership. And I don't work in this repository nearly enough to be confident all of those removals were ok to remove. It's just a reference to show that
isDirectoryIgnored+isFileIgnoredseems to be enough for the rule to go off of.