ci: move types job to pretest workflow

import-js · Nov 19, 2024 · 5fc6cd3 · 5fc6cd3
1 parent b000b19
commit 5fc6cd3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 13 deletions.
diff --git a/.github/workflows/node-4+.yml b/.github/workflows/node-4+.yml
@@ -10,19 +10,6 @@ permissions:
   contents: read
 
 jobs:
-  types:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: ljharb/actions/node/install@main
-        name: 'npm install'
-        with:
-          skip-ls-check: true
-      # for some reason we've got to force typescript to install here
-      # even though the npm script has `typescript@latest`
-      - run: npm i --force typescript@latest
-      - run: npm run test-types
-
   matrix:
     runs-on: ubuntu-latest
     outputs:

diff --git a/.github/workflows/node-pretest.yml b/.github/workflows/node-pretest.yml
@@ -18,6 +18,19 @@ jobs:
   #         skip-ls-check: true
   #     - run: npm run pretest
 
+  types:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ljharb/actions/node/install@main
+        name: 'npm install'
+        with:
+          skip-ls-check: true
+      # for some reason we've got to force typescript to install here
+      # even though the npm script has `typescript@latest`
+      - run: npm i --force typescript@latest
+      - run: npm run test-types
+
   posttest:
     runs-on: ubuntu-latest