Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fingertip with stateless DANE #36

Open
wants to merge 144 commits into
base: main
Choose a base branch
from

Conversation

randomlogin
Copy link

Incorporated changes to replace letsdane with sane.

Copy link
Collaborator

@rithvikvibhu rithvikvibhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments and just a few other changes:

  • Remove block height from tray menu and help page
  • remove stop/start from tray menu or use it to enable/disable tunneling
  • update TLD list (tld.go) in fingertip and sane

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated
}
if hnsdCheckpointPath == "" {
home, _ := os.UserHomeDir() //above already fails if it doesn't exist
hnsdCheckpointPath = path.Join(home, ".hnsd")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a new directory, we can probably use fingertip's existing one so all data stays in one place: app.config.Path

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure which is better: if user also has hnsd, then it's better to share the checkpoints location with hnsd.

Copy link
Collaborator

@rithvikvibhu rithvikvibhu Mar 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh forgot about this. If hnsd changes any file format in the future, it shouldn't affect fingertip. Same reason why Bob stores hsd data in its own directory, not in ~/.hsd.

It's also easier for the uninstaller to clean up, deleting one folder clears everything, and doesn't break any other hnsd that may still be installed independently.

And since we're using -t, even the first sync will be pretty fast anyway.

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants