Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --no-tail #427

Merged
merged 1 commit into from
Aug 27, 2024
Merged

add --no-tail #427

merged 1 commit into from
Aug 27, 2024

Conversation

jsonar-cpapke
Copy link
Collaborator

@jsonar-cpapke jsonar-cpapke commented Jul 4, 2024

Closes #426

@dweberJsonar
Copy link

Closes #426

Copy link
Collaborator

@darya-abdollahzadeh darya-abdollahzadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@darya-abdollahzadeh
Copy link
Collaborator

@jsonar-cpapke please add a description explaining why this change is needed. Thanks

@jsonar-cpapke
Copy link
Collaborator Author

See the linked issue - #426

@gabibeyo
Copy link
Collaborator

Failed. Please have a look
@darya-abdollahzadeh
@jsonar-cpapke

Copy link
Collaborator

@gabibeyo gabibeyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed. Please have a look
@darya-abdollahzadeh
@jsonar-cpapke

@jsonar-cpapke
Copy link
Collaborator Author

The jobs failed due to a AWS permission error initially, I was waiting for confirmation that it had been fixed on your side.

@jsonar-cpapke
Copy link
Collaborator Author

Job has been rerun and passed

@gabibeyo
Copy link
Collaborator

I still see two failures. If you approve I will approve the PR

Copy link
Collaborator

@jagdeep-sonar jagdeep-sonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.

@jsonar-cpapke
Copy link
Collaborator Author

I can't merge this PR because of the failing checks, but Terraform Cloud won't pass as it's not meant to run. @gabibeyo can you merge please?

@eytannnaim eytannnaim merged commit 32e7e0a into master Aug 27, 2024
6 of 8 checks passed
@eytannnaim eytannnaim deleted the cpapke/no-tail-hadr branch August 27, 2024 05:43
eytannnaim pushed a commit that referenced this pull request Aug 27, 2024
@eytannnaim
Copy link
Collaborator

You accidentally opened it on master. Fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not "tail" the replication.log when running the arbiter-setup run-replication step
6 participants