Skip to content

refactor: refuse to run transforms on crates that do not compile #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thedataking wants to merge 1 commit into from
Closed

refactor: refuse to run transforms on crates that do not compile #1898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions c2rust-refactor/src/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,15 @@ impl RefactorState {
};
// One extra step for Phase 3: run the analysis passes
let _result = tcx.analysis(());
// Transforms assume a well-typed crate; running them
// over stale or partial typeck results produces bogus
// rewrites or panics far from the real problem.
if tcx.sess.has_errors().is_some() {
tcx.sess.fatal(
"refusing to refactor: the crate has compile errors \
(see diagnostics above)",
);
}
let cx = RefactorCtxt::new_phase_2_3(
session,
max_crate_node_id.unwrap(),
Expand Down
Loading