Skip to content

transpile: parenthesize subexpression of reference expressions if necessary #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2025
Merged

transpile: parenthesize subexpression of reference expressions if necessary #1121

merged 2 commits into from
Feb 24, 2025

Conversation

fw-immunant
Copy link
Contributor

@fw-immunant fw-immunant commented Sep 5, 2024 •
edited by kkysen
Loading

@kkysen kkysen self-requested a review September 5, 2024 22:09
@kkysen kkysen self-assigned this Sep 9, 2024
kkysen
kkysen reviewed Sep 22, 2024
View reviewed changes
Copy link
Contributor

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the test from #1084?

@fw-immunant fw-immunant mentioned this pull request Dec 9, 2024
Open
@fw-immunant fw-immunant force-pushed the fw/parenthesize-ref-to-cast branch from f570f9b to cbff8d5 Compare January 29, 2025 20:42
@fw-immunant fw-immunant requested a review from kkysen January 29, 2025 20:42
@kkysen kkysen merged commit 040ce97 into master Feb 24, 2025
9 checks passed
@kkysen kkysen deleted the fw/parenthesize-ref-to-cast branch February 24, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkysen kkysen kkysen approved these changes

Assignees

@kkysen kkysen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing parentheses on reference applied to a cast
2 participants
@fw-immunant @kkysen