chore(web): timeline bucketing by day #9935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested by running on local instance and check the console network tab as
well as seeing things are rendered correctly on the timeline and the
scrollbar
…On Sun, Jun 2, 2024 at 9:54 AM Jason Rasmussen ***@***.***> wrote:
***@***.**** commented on this pull request.
How did you test this?
—
Reply to this email directly, view it on GitHub
<#9935 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGONL7SYVBGADEHYFVODLA3ZFKCM5AVCNFSM6AAAAABIUUGS7OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOJSGIYDGMRWGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Nice. I was more wondering if you tested with different bucket sizes and distributions. |
|
I am planning to do that once I get home to use a more populated instance
…On Sun, Jun 2, 2024 at 10:50 AM Jason Rasmussen ***@***.***> wrote:
Nice. I was more wondering if you tested with different bucket sizes and
distributions.
—
Reply to this email directly, view it on GitHub
<#9935 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGONL7WRDTXFLYZQMEK6QU3ZFKI7LAVCNFSM6AAAAABIUUGS7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTGY4DKNRSGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
This function still assumes buckets by month and that'll probably cause issues when uploading assets
immich/web/src/lib/stores/assets.store.ts
Line 350 in d1135db
…immich-app/immich into chore/web-bucketing-by-day
|
should it be using localDateTime rather than fileCreatedAt? In some of my external libraries the fileCreatedAt time is the time the backup was taken and not the date the image was taken. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issues of bucket render of a month can make the browser crash if a certain month has more than 4000 or 5000 assets by rendering the bucket by day grouping.