Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: tear down docs infra after PR is merged & release fixes #9893

Merged
merged 2 commits into from
May 30, 2024

Conversation

zackpollard
Copy link
Contributor

No description provided.

@zackpollard zackpollard requested a review from bo0tzz as a code owner May 30, 2024 10:49
@zackpollard zackpollard changed the title ci: incorrect subdomain used for docs ci: tear down docs infra after PR is merged May 30, 2024
@zackpollard zackpollard force-pushed the ci/docs-destroy branch 9 times, most recently from 80152aa to 83477a5 Compare May 30, 2024 11:42
@zackpollard zackpollard changed the title ci: tear down docs infra after PR is merged ci: tear down docs infra after PR is merged & release fixes May 30, 2024
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to proxy this through another workflow?

.github/workflows/docs-destroy.yml Show resolved Hide resolved
Comment on lines +27 to +32
- name: Comment
uses: actions-cool/maintain-one-comment@v3
with:
number: ${{ github.event.number }}
delete: true
body-include: '<!-- Docs PR URL -->'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on instead editing the comment to say something about the preview deployment being removed? Might also be nice as a bit of feedback on whether this workflow broke or such.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"🧹 Cleaned up docs preview"

@zackpollard zackpollard merged commit 53562e8 into main May 30, 2024
24 checks passed
@zackpollard zackpollard deleted the ci/docs-destroy branch May 30, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants