fix(web): empty album stored #9771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remshams
commented
May 26, 2024
| @@ -6,7 +6,7 @@ import type { PageLoad } from './$types'; | |||
| export const load = (async ({ params }) => { | |||
| await authenticate(); | |||
| const [album, asset] = await Promise.all([ | |||
| getAlbumInfo({ id: params.albumId, withoutAssets: true }), | |||
| getAlbumInfo({ id: params.albumId, withoutAssets: false }), | |||
There was a problem hiding this comment.
This is necessary as otherwise the albums with assets get deleted when clicking the back button.
Not sure if this is a performance problem/how expensive the query is in the backend.
There was a problem hiding this comment.
It is and it is quite expensive. Album info should have the asset count in it though.
There was a problem hiding this comment.
Works perfectly, no idea why I missed the property, sorry and thx.
remshams
commented
May 26, 2024
web/src/routes/(user)/albums/[albumId=id]/[[photos=photos]]/[[assetId=id]]/+page.svelte
Outdated
Show resolved
Hide resolved
remshams
force-pushed
the
fix/9657/emtpy-album-stored
branch
4 times, most recently
from
58904f1
to
feec0c4
Compare
alextran1502
changed the title
web/src/routes/(user)/albums/[albumId=id]/[[photos=photos]]/[[assetId=id]]/+page.svelte
Outdated
Show resolved
Hide resolved
remshams
force-pushed
the
fix/9657/emtpy-album-stored
branch
5 times, most recently
from
6b826db
to
bf5ceaa
Compare
danieldietzler
changed the title
remshams
force-pushed
the
fix/9657/emtpy-album-stored
branch
2 times, most recently
from
4f56d46
to
d90552a
Compare
remshams
force-pushed
the
fix/9657/emtpy-album-stored
branch
from
d90552a
to
e7a99bb
Compare
michelheusschen
approved these changes
Jun 2, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was annoyed by #9657 so I fixed it on may local version.
The idea is to remove and empty album (without assets) when navigating back (clicking the close button) from the album create page instead of cleaning up when navigating to the albums page.
However I'm just starting to get familiar with the code, so I don't know if there are any side effects I'm not aware of...
The alternative would be to do the same cleanup when e.g. when adding a a photo to an album (in the "photos" section).
The advantage of doing it on closing is that it only needs to done once and it also avoids the flickering when opening the "albums" section (the empty album is visible just before it is deleted).
Please let me know if it is useful for you.