Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve backup UX #8533

Closed
wants to merge 6 commits into from
Closed

Improve backup UX #8533

wants to merge 6 commits into from

Conversation

xethlyx
Copy link
Contributor

@xethlyx xethlyx commented Apr 5, 2024

This attempts to fix these issues/improve these features:

  • Backup file information is permanently visible, even when not backing up
  • HTTP errors in backups cause invisible errors to the user
  • Malformed error responses cause invisible errors to the user (e.g. file too large errors from a reverse proxy)
  • If an error occurs in the last asset in a manual backup, then the backup UI would never finish
  • Improve UX of manual backup

No longer planned (I was not aware that background backups gave error notifications):

  • Display background backup errors in the UI
  • Add a notifier on the main screen on the backup icon if any backups failed

Some considerations:

  • Should users be prompted about the newly detected HTTP errors? Someone could be running Immich only in their local network, so should they need to be notified if an upload failed while they were roaming?

UI Screenshots:

image
image
image
image
image

This is currently a work-in-progress and I will be updating this description as I work.

@xethlyx
Copy link
Contributor Author

xethlyx commented Apr 6, 2024

@Chaphasilor
Copy link

I'd suggest giving the user a way to enable automatic backup along with the "Automatic backup is disabled" message. The button could say something like "Change backup settings" or even "Enable automatic backup" and would then do the same as clicking the gear icon at the top.

@zackpollard
Copy link
Contributor

Hey, the fixes in this PR look promising. For the UI I think we like the approach but will probably want to make some further changes to get it more in-line with the design of the rest of the app. For the non-UI changes, are those ready to go? What else is needed to get this PR into a state ready for review? Cheers!

@xethlyx
Copy link
Contributor Author

xethlyx commented May 2, 2024

Hi, the only other change that's needed right now I believe is just to fix some of my UI hacks: https://github.com/immich-app/immich/pull/8533/files#diff-c00a7c028bb7ba1ec21f707165486dea93043cf04d556a7a753f5a589507a3d8R343

@alextran1502
Copy link
Contributor

I am closing this as it is now stale and need a lot of UI work to adapt with Immich's design language. Thanks for the idea, I will definitely return to this UI work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants