-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mobile): Folder View for mobile #15047
base: main
Are you sure you want to change the base?
Conversation
Thanks for the feedback Alex, I implemented your suggested fixes as well as I could. I have now tried to implement the loading of assets by creating a new Provider, however something is not working yet. |
Thanks again for your fix @shenlong-tanwen <3 I have now implemented:
What's missing for a "beta" release:
Improvements, which could potentially be saved for a follow-up PR:
|
Alrighty, I've got it to a working and imo acceptable state in my testing, I think we could start testing and if not critical bugs are gound, we could merge this. The additional improvements mentioned above would be for a follow up PR |
General Idea
Implementation Idea
My rough Idea was to have one single state representing the entire folder structure, since that can be derived from a single api call.
And then, whenever a folder gets navigated to, the assets for that specific folder could get fetched, and also saved in that state.
That way (I hope) you could navigate out and back in again without having to refetch the assets, since they would still be saved in state.
So far
Since I have basically no experience with complex Flutter projects or Flutter State Management, this is gonna be rough, but i've hacked together a somewhat functional prototype that fetches the folders and lets you navigate through them.
Asset loading is not yet implemented, since I am sure there are already plenty of basic improvements that could be made at this stage from more experience devs regarding the entire state and fetching logic.