Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): use the earliest date between file creation and modification timestamps when missing exif tags #14874

Merged
merged 10 commits into from
Jan 2, 2025

Conversation

Chuckame
Copy link
Contributor

I also applied the date extraction for motion asset creation, tell me if I need to rollback this part, maybe it was wanted to not re-use getDates.

Closes #14857

Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please address the comments

@alextran1502 alextran1502 changed the title feat(server): Use the earliest date between file creation and modification timestamps when missing exif tags feat(server): use the earliest date between file creation and modification timestamps when missing exif tags Dec 23, 2024
server/src/services/metadata.service.ts Outdated Show resolved Hide resolved
@Chuckame
Copy link
Contributor Author

Chuckame commented Jan 2, 2025

Hello there, happy new year, I hope there is nothing missing to merge 🤞

@alextran1502 alextran1502 enabled auto-merge (squash) January 2, 2025 04:44
@alextran1502
Copy link
Contributor

Happy new year and thank you!

@alextran1502 alextran1502 merged commit 3c35b46 into immich-app:main Jan 2, 2025
33 checks passed
yosit pushed a commit to yosit/immich that referenced this pull request Jan 13, 2025
…ation timestamps when missing exif tags (immich-app#14874)

* feat(server): Use the earliest date between file creation and modification timestamps when missing exif tags

* PR fixes

* PR fixes

* Switch log to debug

* fix linter for min date

* apply prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date fallback should be the earliest between creation and modification dates
4 participants