-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): use the earliest date between file creation and modification timestamps when missing exif tags #14874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextran1502
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please address the comments
alextran1502
changed the title
feat(server): Use the earliest date between file creation and modification timestamps when missing exif tags
feat(server): use the earliest date between file creation and modification timestamps when missing exif tags
Dec 23, 2024
Chuckame
commented
Dec 23, 2024
danieldietzler
approved these changes
Dec 23, 2024
…ation timestamps when missing exif tags
danieldietzler
approved these changes
Dec 26, 2024
Hello there, happy new year, I hope there is nothing missing to merge 🤞 |
Happy new year and thank you! |
3 tasks
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Jan 13, 2025
…ation timestamps when missing exif tags (immich-app#14874) * feat(server): Use the earliest date between file creation and modification timestamps when missing exif tags * PR fixes * PR fixes * Switch log to debug * fix linter for min date * apply prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also applied the date extraction for motion asset creation, tell me if I need to rollback this part, maybe it was wanted to not re-use
getDates
.Closes #14857