fix(server): support import paths with special chars #14856
Merged
+62
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etnoy
force-pushed
the
fix/asterisk-import-path
branch
from
68ffe33 to
f7d628d
Compare
alextran1502
approved these changes
Dec 22, 2024
| @@ -214,7 +214,7 @@ export class StorageRepository implements IStorageRepository { | |||
| } | |||
|
|
|||
| private asGlob(pathToCrawl: string): string { | |||
There was a problem hiding this comment.
why is there a square bracket?
There was a problem hiding this comment.
Around the special characters? Turns out, that's how you escape double quotes, single quotes and asterisks when using a dynamic glob pattern. A literal " is written as ["]
danieldietzler
approved these changes
Dec 22, 2024
| @@ -214,7 +214,7 @@ export class StorageRepository implements IStorageRepository { | |||
| } | |||
|
|
|||
| private asGlob(pathToCrawl: string): string { | |||
| const escapedPath = escapePath(pathToCrawl); | |||
| const escapedPath = escapePath(pathToCrawl).replaceAll('"', '["]').replaceAll("'", "[']").replaceAll('`', '[`]'); | |||
There was a problem hiding this comment.
It's so freaking annoying that there isn't just a library escapePath function that does it all...
There was a problem hiding this comment.
We uncover all kinds of bugs in libraries, I should probably file this as an issue with fast-glob. Likely we are the first ones to even notice
mertalev
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14588
It was not possible to have an import path with apostrope, double quote, asterisk and so on. Now it works.
Also adds support for several other special characters, except for backslash which seems like a special category of difficult