chore(docs): Update nginx example config #13016
Open
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tweak in nginx example should make all request made by immich web app go through SSL by default, not requiring other ports than 443 opened to outboud connections.
github-actions
bot
added
the
documentation
|
This is generally a sensible thing to do, but I'm not sure how I feel about it here since we deliberately keep these configs as minimal as possible and it doesn't have any HTTPS config for that reason. |
|
Thanks for the quick reaction. I will only add that I did not know how or whether to update Caddy, Apache, and Traefik in a similar fashion - that might be a thing missing in this PR even if changing nginx would look like a good idea. The reason I created this PR anyway was that the TLS was basically the only reason I set up a reverse proxy for my instance. But I might be side-tracking a bit: So let's close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweak in the nginx example should make all requests made by immich web app go through the SSL.
I stumbled upon the lack of the header when setting up nginx to redirect wan traffic to an immich instance and noticed a lot of tracking still wanting to use HTTP instead of HTTPS protocol.