Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(server): events #13003

Merged
merged 2 commits into from
Sep 30, 2024
Merged

refactor(server): events #13003

merged 2 commits into from
Sep 30, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Sep 27, 2024

  • Simplify the event system
  • Remove EventEmitter2
  • Transition to .emit and .on for events from other websocket servers (connected api/microservices instances)
  • Replace config$.next and config$.subscribe with OnEvent({ event: 'config.update' })
  • Add an option to also respond events (config.update) from other "server" instances

@jrasm91 jrasm91 merged commit a2d457b into main Sep 30, 2024
35 checks passed
@jrasm91 jrasm91 deleted the refactor/events branch September 30, 2024 14:35
yosit pushed a commit to yosit/immich that referenced this pull request Oct 3, 2024
* refactor(server): events

* chore: better type

---------

Co-authored-by: Daniel Dietzler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants