-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web) : User removal from option menu on the top in shared album #12959
base: main
Are you sure you want to change the base?
fix(web) : User removal from option menu on the top in shared album #12959
Conversation
Can you please stop opening and closing PRs? If this continues we will have to block your from the organization. If you need help or have a question please ask it instead. |
Really sorry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, could you add few type hints to your update code?
…/user-removal-from-option-menu-on-the-top-in-shared-album
…album' of https://github.com/Pranav-8bit/immich into fix/user-removal-from-option-menu-on-the-top-in-shared-album
@vignesh1507 I have added a few more type hints you can check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the response and for adding type hints in the code file @Pranav-8bit
@vignesh1507 what are you even talking about? What is going on here? |
I asked @Pranav-8bit for adding comments/type hints in the code file which he changed and as i requested added few type hints in the code. That's what happening here @jrasm91. Hope this comment summarises the conversation in this PR. |
@jrasm91 Is there something wrong? I didn't get it. Is this guy not legit? |
They have no affiliation with the project so you can just ignore them. |
In this PR, I have fixed the issue where users could not be removed from the top options menu in a shared album, as described in issue #7954