Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web) : User removal from option menu on the top in shared album #12959

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Pranav-8bit
Copy link

In this PR, I have fixed the issue where users could not be removed from the top options menu in a shared album, as described in issue #7954

@jrasm91
Copy link
Contributor

jrasm91 commented Sep 26, 2024

Can you please stop opening and closing PRs? If this continues we will have to block your from the organization. If you need help or have a question please ask it instead.

@Pranav-8bit
Copy link
Author

Really sorry

Copy link

@vignesh1507 vignesh1507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, could you add few type hints to your update code?

@Pranav-8bit
Copy link
Author

@vignesh1507 I have added a few more type hints you can check

Copy link

@vignesh1507 vignesh1507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the response and for adding type hints in the code file @Pranav-8bit

@jrasm91
Copy link
Contributor

jrasm91 commented Sep 28, 2024

@vignesh1507 what are you even talking about? What is going on here?

@vignesh1507
Copy link

I asked @Pranav-8bit for adding comments/type hints in the code file which he changed and as i requested added few type hints in the code. That's what happening here @jrasm91. Hope this comment summarises the conversation in this PR.

@Pranav-8bit
Copy link
Author

Pranav-8bit commented Sep 28, 2024

@jrasm91 Is there something wrong? I didn't get it. Is this guy not legit?

@jrasm91
Copy link
Contributor

jrasm91 commented Sep 28, 2024

They have no affiliation with the project so you can just ignore them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants