Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): memory viewer #12649

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix(web): memory viewer #12649

merged 1 commit into from
Sep 13, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Sep 13, 2024

Fix a few bugs with the memory viewer component.

danieldietzler
danieldietzler approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alextran1502
alextran1502 approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the navigation in asset viewer

@jrasm91 jrasm91 merged commit a373d50 into main Sep 13, 2024
36 checks passed
@jrasm91 jrasm91 deleted the refactor/memory-viewer branch September 13, 2024 16:27
@ben-basten
Copy link
Member

Does this fix #10415 too?

@jrasm91 jrasm91 mentioned this pull request Sep 13, 2024
Closed
3 tasks
@timtor-bot timtor-bot mentioned this pull request Oct 30, 2024
Open
1 task
This was referenced Nov 2, 2024
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler approved these changes

@alextran1502 alextran1502 alextran1502 approved these changes

Assignees
No one assigned
Labels
changelog:bugfix 🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navigating using arrow keys in a gallery under memories switches view back to the timeline
4 participants
@jrasm91 @ben-basten @alextran1502 @danieldietzler