fix(server): increase person search limit #12619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
approved these changes
Sep 12, 2024
mertalev
reviewed
Sep 12, 2024
There was a problem hiding this comment.
- On web,
maximumLengthSearchPeopleis still fixed at 20. - Web should only start searching at the second character to ease server load; it's likely to get 500 results with just one character.
- Not a blocker for this PR, but the group by / count likely makes this much less responsive for large libraries. It'd be snappy at any library size if it didn't do that.
jrasm91
force-pushed
the
fix/person-search-limit
branch
from
2d40aeb
to
ae610a3
Compare
jrasm91
force-pushed
the
fix/person-search-limit
branch
from
ae610a3
to
97d45c9
Compare
|
@mertalev - thanks for the hint about (1), which I've changed to 1,000 now (aligns with the server). I've skipped (2) as it was not an easy fix given the current state of the web components, but I have implemented (3) which should at least make (2) less of an issue. |
mertalev
approved these changes
Sep 13, 2024
1 task
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the person search results from 20 to 500. In the future we can look at making this endpoint paginated if needed.
Fixes #8822