Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): bucket by localDateTime #12612

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix(web): bucket by localDateTime #12612

merged 1 commit into from
Sep 12, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Sep 12, 2024

  • Use localDateTime for bucketing
  • Use fileCreatedAt for sorting

The server buckets by localDateTime but the web for whatever reason was still using fileCreatedAt.

Fixes #8243

@jrasm91 jrasm91 added changelog:bugfix date-time Issues with date/time/time zone labels Sep 12, 2024
alextran1502
alextran1502 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on my stress test instance

@jrasm91 jrasm91 merged commit 15f9ff1 into main Sep 12, 2024
37 checks passed
@jrasm91 jrasm91 deleted the fix/web-bucketing branch September 12, 2024 19:30
@sirweazel sirweazel mentioned this pull request Sep 13, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextran1502 alextran1502 alextran1502 approved these changes

@danieldietzler danieldietzler danieldietzler approved these changes

Assignees
No one assigned
Labels
changelog:bugfix date-time Issues with date/time/time zone 🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Date is not in order
3 participants
@jrasm91 @alextran1502 @danieldietzler