Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): clip scrollbar overflow in modals #12526

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix(web): clip scrollbar overflow in modals #12526

merged 1 commit into from
Sep 10, 2024

Conversation

ben-basten
Copy link
Member

@ben-basten ben-basten commented Sep 9, 2024 •
edited
Loading

Description

Improve the look and feel of the scrollbar in modals.

  • visually clip any scrollbar that overflows outside of the rounded corners
  • padding on the top and bottom of the scroll container, so the scrollbar doesn't span the whole height of the modal

Prerequisite for #12438.

Screenshots

Safari example

safari-scrolling-modal

Chrome example (MacOS)

chrome-scrolling-modal

@ben-basten ben-basten requested review from alextran1502 and removed request for alextran1502 September 9, 2024 23:02
@ben-basten ben-basten marked this pull request as ready for review September 9, 2024 23:19
alextran1502
alextran1502 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks <3

@alextran1502 alextran1502 merged commit 009a140 into main Sep 10, 2024
35 checks passed
@alextran1502 alextran1502 deleted the fix/chop-scrollbar branch September 10, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextran1502 alextran1502 alextran1502 approved these changes

Assignees
No one assigned
Labels
changelog:skip 🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben-basten @alextran1502