Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize copy image to clipboard #12366

Merged
merged 7 commits into from
Sep 6, 2024

Conversation

martabal
Copy link
Member

@martabal martabal commented Sep 5, 2024

Remove the copy-image-clipboard dependency. When copying the asset to the clipboard, use the asset from the photoviewer instead of doing a new network request.

@martabal martabal force-pushed the feat/optimize-copy-image-to-clipboard branch from 4dba87b to a376626 Compare September 5, 2024 18:41
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

web/src/lib/i18n/en.json Outdated Show resolved Hide resolved
web/src/lib/utils/asset-utils.ts Outdated Show resolved Hide resolved
web/src/lib/utils/asset-utils.ts Outdated Show resolved Hide resolved
@jrasm91
Copy link
Contributor

jrasm91 commented Sep 5, 2024

I tested this an confirmed copying images still works as expected.

@alextran1502 alextran1502 merged commit a653d9d into main Sep 6, 2024
29 checks passed
@alextran1502 alextran1502 deleted the feat/optimize-copy-image-to-clipboard branch September 6, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants