New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): byte units enum #11161

Merged

jrasm91 merged 1 commit into main from fix/web-byte-units

Jul 17, 2024

Contributor

michelheusschen commented Jul 17, 2024

Returning the byte unit as a numeric enum in getBytesWithUnit is error-prone:

Manual mapping to a string can be forgotten
ByteUnit.B is zero and thus falsy, causing issues with if (unit) checks

Switching to a string enum solves these problems. This also fixes an issue I saw on discord for small viewports (the 3 should be GiB):


          fix(web): byte units enum

5092cd8

michelheusschen added the 🖥️web label

danieldietzler approved these changes

View reviewed changes

Member

danieldietzler left a comment

Nice, thank you!

jrasm91 approved these changes

View reviewed changes

jrasm91 merged commit e3fd766 into main

22 checks passed

jrasm91 deleted the fix/web-byte-units branch

July 17, 2024 11:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels