feat(server): conditionally run facial recognition nightly #11080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
reviewed
Jul 14, 2024
mertalev
force-pushed
the
feat/smarter-facial-recognition-nightly
branch
from
aad1512
to
497c689
Compare
jrasm91
reviewed
Jul 15, 2024
| this.repository.getLatestFaceDate(), | ||
| ]); | ||
|
|
||
| if (state?.lastRun && latestFaceDate && state.lastRun > latestFaceDate) { |
There was a problem hiding this comment.
Is this a string compare? Does that even work?
There was a problem hiding this comment.
Yes, since they're both ISO strings.
There was a problem hiding this comment.
I tested by hardcoding nightly: true. The first time it ran (since there was no system metadata entry) and the second time it skipped.
There was a problem hiding this comment.
Ok. Maybe we should add a comment or something. I think it isn't very obvious, which makes it an easy place to introduce a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The facial recognition nightly currently runs every night, but there's no need when no new face has been detected since the last run.
This PR stores the last run date in the system metadata table and compares it with the newest
facesRecognizedAtvalue in the job status table. It only does this in the nightly; manual runs still behave like before.The query for getting the latest face detection date is a full table scan, but it isn't worth indexing the column just for one non-interactive query a day. It at least avoids sorting.
Resolves #11078