Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "immich-form-label" class for combobox label #10254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flesser
Copy link

@flesser flesser commented Jun 13, 2024

On the "Edit date and time" dialog I noticed that the font sizes between the two input labels were different:
before

This PR changes the combobox label to use the existing immich-form-label CSS class instead of tailwind's text-sm:
after

The spacing is still off, but this may be fixed in a different PR (or in a later edit of this one).

As far as I can tell, the "Edit date and time" dialog is currently the only place where a combobox with visible label is used. In the settings pages, all the comboboxes have their label hidden.

(Kudos for having such a smooth and simple https://immich.app/docs/developer/setup/ which makes it really low-threshold to contribute! ❤️ )

@michelheusschen
Copy link
Contributor

Thanks for the PR. The combobox is also used in the search bar where the label color changes slightly, but I don't think that's an issue:

Before
search-options-before

After
search-options-after

If you could also adjust the spacing of Date and Time to match, that would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants