Use "immich-form-label" class for combobox label #10254
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the "Edit date and time" dialog I noticed that the font sizes between the two input labels were different:
![before](https://private-user-images.githubusercontent.com/510681/339237158-d6713c0b-6545-4122-a009-e0b685864b45.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0Nzk2MzQsIm5iZiI6MTcxOTQ3OTMzNCwicGF0aCI6Ii81MTA2ODEvMzM5MjM3MTU4LWQ2NzEzYzBiLTY1NDUtNDEyMi1hMDA5LWUwYjY4NTg2NGI0NS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyN1QwOTA4NTRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03Y2M0ODQxNjJlZmFkZDE5ZmJiMDY3YThmYWNlNDQwN2NjZmE0NmI2NjllMGQ1ZWViZWEyMWRhYTYwMWU1OGViJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.yNuVUgEKCMvgrcv8SNi6zSu30ucPQxdgWNO0BYKMt1k)
This PR changes the combobox label to use the existing
![after](https://private-user-images.githubusercontent.com/510681/339237196-5d937a45-61a4-45db-8121-d8a1196f11ac.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0Nzk2MzQsIm5iZiI6MTcxOTQ3OTMzNCwicGF0aCI6Ii81MTA2ODEvMzM5MjM3MTk2LTVkOTM3YTQ1LTYxYTQtNDVkYi04MTIxLWQ4YTExOTZmMTFhYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyN1QwOTA4NTRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04YzIwY2U1OWU3OWJiNjk0MTUzN2I0NDQ3YWUzZWU2ZDZkMTM5ZjVjOWQyNjczNjE2OWY5NTI0ZTYyZmI2NzhjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.gXLNwpgNsJpsz_UxabHFE-Tol_ysBjdWB_q5IYAKGGU)
immich-form-label
CSS class instead of tailwind'stext-sm
:The spacing is still off, but this may be fixed in a different PR (or in a later edit of this one).
As far as I can tell, the "Edit date and time" dialog is currently the only place where a combobox with visible label is used. In the settings pages, all the comboboxes have their label hidden.
(Kudos for having such a smooth and simple https://immich.app/docs/developer/setup/ which makes it really low-threshold to contribute! ❤️ )