fix(server): fix modify date extraction (#12658)

* fix(server): fix modify date extraction * add unit test
immich-app · Sep 14, 2024 · e73dc3d · e73dc3d
1 parent f22338f
commit e73dc3d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/server/src/services/metadata.service.spec.ts b/server/src/services/metadata.service.spec.ts
@@ -1095,6 +1095,18 @@ describe(MetadataService.name, () => {
       expect(personMock.updateAll).toHaveBeenCalledWith([]);
       expect(jobMock.queueAll).toHaveBeenCalledWith([]);
     });
+
+    it('should handle invalid modify date', async () => {
+      assetMock.getByIds.mockResolvedValue([assetStub.image]);
+      metadataMock.readTags.mockResolvedValue({ ModifyDate: '00:00:00.000' });
+
+      await sut.handleMetadataExtraction({ id: assetStub.image.id });
+      expect(assetMock.upsertExif).toHaveBeenCalledWith(
+        expect.objectContaining({
+          modifyDate: expect.any(Date),
+        }),
+      );
+    });
   });
 
   describe('handleQueueSidecar', () => {

diff --git a/server/src/services/metadata.service.ts b/server/src/services/metadata.service.ts
@@ -629,11 +629,16 @@ export class MetadataService {
       this.logger.debug(`Asset ${asset.id} local time is offset by ${offsetMinutes} minutes`);
     }
 
+    let modifyDate = asset.fileModifiedAt;
+    try {
+      modifyDate = (exifTags.ModifyDate as ExifDateTime)?.toDate() ?? modifyDate;
+    } catch {}
+
     return {
       dateTimeOriginal,
       timeZone,
       localDateTime,
-      modifyDate: (exifTags.ModifyDate as ExifDateTime)?.toDate() ?? asset.fileModifiedAt,
+      modifyDate,
     };
   }