Skip to content

Question support #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Question support #104

wants to merge 28 commits into from

Conversation

@aspalding
Copy link
Contributor

@aspalding aspalding commented Oct 30, 2023

aspalding added 25 commits October 10, 2023 16:55
super rough test
04a832e
verbose test output
6d3cc9e
track responses in collection
f8c006e
consistent vocabulary
46f4b5e
remove code committed in error
410cb38
start testing question colletions get updated
a6b5d48
wip updating reply collection
724f27b
update original object to reflect votes
65106c8
solve voterCount for the most simple test case
2590bb3
write a test for and support anyOf
5d7ac60
test and implementation for publishing results
6f40b76
test to validate voting is blocked on closed polls
ae063a1
adjust order so linked property is available for more validations
8103fc0
validate the polls are still open
29ecafb
write test to prevent a user from voting for the same option twice
a403aa6
refactor variable name
ed26bfe
test cleanup, put in basis of incomplete change
4b060c7
get test to fail as expected
2f56463
cleanup and comment, to return
1ad5bbb
have resolve thread get meta
ba5d724
change how voters are counted, remove validations from side effects
6c44661
implement oneOf, WIP anyOf
553eabf
fix other validations
d557f0a
refactor unneeded code
777848f
cleanup white space, comments
15e12b9
@aspalding aspalding requested a review from wmurphyrd October 30, 2023 15:23
@aspalding aspalding closed this Dec 22, 2023
@wmurphyrd wmurphyrd reopened this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmurphyrd wmurphyrd Awaiting requested review from wmurphyrd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aspalding @wmurphyrd